search

moul / node-gitlab

DEPRECATED, see https://github.com/node-gitlab/node-gitlab
https://npmjs.org/package/gitlab
Other
470 stars 140 forks source link

is the builds api implemented? #119

Closed coyotebringsfire closed 5 years ago

coyotebringsfire commented 8 years ago

I don't know coffeescript, but when I look around, it doesn't look like the api to query build status has been implemented. I want this functionality, and I'm willing to implement it, but I don't want to reinvent the wheel

dave-irvine commented 8 years ago

No this isn't something we've implemented yet, I think the Builds API landed when they merged in Gitlab CI and we haven't had a major update since before then.

I'm still trying to find the time to redo this library in ES6.

coyotebringsfire commented 8 years ago

I'm getting ready to submit a PR for the builds API calls to get a single build and get a list of all builds for a project. Should I include the js files built by running 'cake build' in addition to the coffee script files?

moul commented 8 years ago

@coyotebringsfire, if possible, make a dedicated commit just for the generated js files, but that's a bonus

dave-irvine commented 8 years ago

@coyotebringsfire Here is an example: https://github.com/node-gitlab/node-gitlab/pull/107/commits

kiddouk commented 8 years ago

It's been implemented here : https://github.com/node-gitlab/node-gitlab/blob/develop/src/Models/ProjectBuilds.coffee