Is this library still maintained ?

moul / node-gitlab

DEPRECATED, see https://github.com/node-gitlab/node-gitlab

https://npmjs.org/package/gitlab

Other

470 stars 140 forks source link

Is this library still maintained ? #191

Closed bufferoverflow closed 5 years ago

bufferoverflow commented 6 years ago

A lot of people started to use node-gitlab-api which is quite well maintained.

There is a discussion about the name of the package, see https://github.com/jdalrymple/node-gitlab-api/issues/30

If this library here is unmaintained, the npm name could probably passed over to the more active project, so people can find the lib easily.

What do you think?

dave-irvine commented 6 years ago

I helped maintain this project while I still had repos on a gitlab instance, but this is no longer the case so my interest has dropped off.

The repo + npm name belongs to @moul though, its up to him if he wants to give it up.

moul commented 6 years ago

I’m not specifically attached to the package name

What the best way to make the migration painless for people using this package today ?

bufferoverflow commented 6 years ago

a breaking change notice, info within this repo‘s README.md and bump major version number. API compatibility is something that has to be checked. However, it started as a fork und is now a rewrite so showing this with a major version change should be sufficient. See https://github.com/jdalrymple/node-gitlab-api/blob/master/README.md#contributors

bufferoverflow commented 6 years ago

I recommend to pass the gitlab npm package over to @jdalrymple , so he can publish 3.0.0 , his username on npm is https://www.npmjs.com/~jdalrymple and mark this repo here as deprected.

moul commented 6 years ago

@bufferoverflow I added @jdalrymple as maintainer on npm, don't know if it's enough for him to continue?

jdalrymple commented 6 years ago

I'll try tonight! Thanks :)

jdalrymple commented 6 years ago

@moul I was able to publish the newest version under the gitlab npm package! Seemed to have worked well.

bufferoverflow commented 6 years ago

@moul , @jdalrymple awesome collaboration!

Shall I create a MR to the README within this repo so people know about the state?
What are your ideas in regard of the source code repo ?
Does is make sense to rename https://github.com/node-gitlab/node-gitlab/ to https://github.com/node-gitlab/node-gitlab-old/ and move https://github.com/jdalrymple/node-gitlab-api/ to https://github.com/node-gitlab/node-gitlab/ ?

jdalrymple commented 6 years ago

Yea :smile: thanks @moul !!!

A update in the README would be wicked if you find the time!

Not sure what to do about the source code repo, the node-gitlab group is a lil outdated with the most recent thing being since 2015 :(. I could rename the node-gitlab-api repo if it would make it easier to understand?

jdalrymple commented 5 years ago

Hey! So what was the consensus ?