search

moul / protoc-gen-gotemplate

:open_file_folder: generic protocol generator based on golang's text/template (grpc/protobuf)
https://manfred.life/protoc-gen-gotemplate
MIT License
438 stars 70 forks source link

fix: error with multiple files and custom options #176

Closed Mik- closed 3 years ago

Mik- commented 3 years ago

This pull request fixes #150. I also fixed concurrent map read/write errors, when processing multiple template files.

Mik- commented 3 years ago

@moul do I have to do something further here? Unfortunately I can't remove the WIP label and I think, the linter warnings about deprecated dependencies should be solved in another pull request as it could be a breaking change.

moul commented 3 years ago

Hey @Mik- :wave:, thank you for this PR, and sorry, I didn't open the details of the golangci-lint issue, I though it was something added by you, I'll make a full review later today

djale1k commented 3 years ago

@moul @Mik- there's some deprecated methods from protobuf on added lines we should change them SA1019: proto.RegisteredExtensions is deprecated: Use protoregistry.GlobalTypes.RangeExtensionsByMessage instead. (staticcheck)

djale1k commented 3 years ago

@Mik- now it's great thank you! :) Just change the imports they are also depr

Mik- commented 3 years ago

Just changing the imports is not that easy. The Plugin-API has changed, too. So it would be a bigger rework.

moul commented 3 years ago

Thank you! And sorry for the delay :)

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.11.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: