search

mounilsankar / pe

0 stars 0 forks source link

Undo command does not work as advertised #6

Open mounilsankar opened 7 months ago

mounilsankar commented 7 months ago

The user guide mentions that the undo command undos the commands from the creation of the app as shown in the screenshot below

Screenshot 2023-11-17 at 4.45.12 PM.png

However when the user exits from the app and reopens the app the commands executed in the previous run cannot be undone

Steps to be reproduce:

  1. Open the application
  2. Execute add n/Gosadasogle r/Software Engineering c/Summer 2024 s/Offered d/25 Oct 2023
  3. Close the app.
  4. Reopen the app.
  5. Execute undo.
  6. Message output shown below with the added application still in system.

Screenshot 2023-11-17 at 4.45.25 PM.png

Possible remedy: Update user guide to inform users that only changes in the current run can be undone.

nus-pe-script commented 7 months ago

Team's Response

This is intended behaviour as of v1.4. As specified in the UG, the undo command can only revert any changes since starting the application. So if you close the application and start it up again, you can only revert commands made after this point. However, the suggestion is much appreciated! We do think this could be done in future iterations to improve our app.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: This should certainly be a bug as there is a mismatch between the undo command's behaviour in the app and the the behaviour specified in your UG. This classifies as a functionality bug. I think the team interprets the start of the application as the current run, however most readers would think start of the application refers to when the application was first downloaded given the way it is worded in the UG

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** There is a mismatch between the undo command's behaviour in the app and the the behaviour specified in your UG. This classifies as a functionality bug.