search

mountainMath / cancensus

R wrapper for calling CensusMapper APIs
https://mountainmath.github.io/cancensus/index.html
Other
82 stars 15 forks source link

add enhancement with child census vectors and future functionality for tax data #136

Closed mountainMath closed 4 years ago

mountainMath commented 4 years ago

fixes https://github.com/mountainMath/cancensus/issues/134 and adds support for future tax data release

mountainMath commented 4 years ago

Ok, fixed the parent_census_vectors call. And moved the census_regions stuff into a separate file to make things cleaner. Also changed the caching behaviour of list_census_regions and list_census_vectors to cache for duration of running R session by default. Should make things run smoother.

dshkol commented 4 years ago

Added some tweaks to the documentation and examples that were bothering me or were in need of an update for new syntax.

dshkol commented 4 years ago

If there's no CRAN check issues or notes (I had one, but it seemed specific to my local directory), happy to push this one into master and move to submit the update to CRAN

mountainMath commented 4 years ago

CRAN check looks good on my end. Only other thing I can think of is adding tests. Maybe leave that for the next release? 😁

dshkol commented 4 years ago

Should be added, but I think can wait for the next one.

dshkol commented 4 years ago

Let's merge and submit then?