search

mountainMath / cancensus

R wrapper for calling CensusMapper APIs
https://mountainmath.github.io/cancensus/index.html
Other
82 stars 15 forks source link

V0.5.1 #183

Closed mountainMath closed 2 years ago

mountainMath commented 2 years ago

Placeholder for next release. Still needs to incorporate https://github.com/mountainMath/cancensus/issues/181, https://github.com/mountainMath/cancensus/issues/180, https://github.com/mountainMath/cancensus/issues/179, and https://github.com/mountainMath/cancensus/issues/182.

dshkol commented 2 years ago

What is geo_suite meant to do?

mountainMath commented 2 years ago

It’s supposed to access GeoSuite data. That’s basically a comprehensive file for each geographic level with all higher level geographic identifiers, and also population, household and dwelling counts. It’s useful for traversing geographic hierarchies and much easier and faster than downloading data bit by bit from CensusMapper.

mountainMath commented 2 years ago

GeoSuite wasn't part of any prior release, I added this in for the current release. But there are several issues that have to be worked out before it's ready.

  1. The R unzip functions can't handle it, or at least not in a cross-platform way because of special characters in file names.
  2. The data is inconsistently organized across census years.

Maybe one way around this is that I first do some pre-processing and then dump them as files on CensusMapper or in an S3 bucket and the package accesses the cleaned data from there.

mountainMath commented 2 years ago

I think everything is implemented, except for the install checks for {sf}. Should we bump that to the next version @dshkol?

dshkol commented 2 years ago

Noticed that geo_suite.R file is still present, and cancensus:::get_geo_suite() still exists in the namespace. Is that intended?

dshkol commented 2 years ago

I think everything is implemented, except for the install checks for {sf}. Should we bump that to the next version @dshkol?

I can still add that but am swamped with work this week. If you want to try and push this version to CRAN, we can defer it til next time and focus on that in the next couple days pending my questions around automatically checking recall status.

mountainMath commented 2 years ago

The geo_suite file is still part of the repo but added to the .Rbuildignore, will check into why it's part of the namespace. Left the file in there as a working stub, but it seems it still shows up in the namespace and that's an issue. Will experiment how to get rid of it completely, might just move it into a separate branch.

The geo_suite file won't be part of the package because it's listed in the .Rbuildignore, it's only part of the namespace when the GitHub version is cloned and compiled. If you install from CRAN or via remotes the file won't be included. One way to test this is to check for the generate_cancensus_sticker() function in the namespace, that one has been part of the code for a long time but is excluded via .Rbuildignore.