search

mountainMath / cansim

Wrapper to access CANSIM data
Other
44 stars 5 forks source link

dev v0.3.6 #79

Closed dshkol closed 3 years ago

dshkol commented 4 years ago

Starting a draft to prepare this branch for next version updates and any downstream changes for the next CRAN release.

Proposed :

1) Adding a method for precompiling vignettes. @mountainMath - have you tested this works and addresses current issues?

2) Replace deprecated dplyr/tibble function calls etc

mountainMath commented 4 years ago

I am not sure we need the precompiled vignette. We did not do anything to {cancensus} and all the vignettes show up just fine on CRAN. Not sure why and how, maybe that gets somehow folded in when compiling pkgdown documentation?

I have to admit I still don't know what the precompile vignette part does.

dshkol commented 4 years ago

I wasn't sure either - but leaving it to you. Are there other changes here besides the precompiled vignette that need to be incorporated? Can cherry pick those commits only.

mountainMath commented 4 years ago

It's been a long time coming with the precompile-vignette branch, but I am leaning toward pushing it off for another round and see if our usual process can get the vignettes precompiled just like it did not {cancensus}. The only change that was needed for {cancensus} was to add the vignette: field to the header and the vignettes showed up.

dshkol commented 4 years ago

@mountainMath - Let's roll the fixes for #80 and #81 in here when they are ready?