mountainMath / cansim

Wrapper to access CANSIM data
Other
44 stars 5 forks source link

Timeout in get_cansim_vector #81

Closed mountainMath closed 3 years ago

mountainMath commented 4 years ago

Expose timeout variable to allow shorter timeout. Maybe also set default to be shorter.

Also think about caching the data for the session duration. We do this for other calls, but not for this one.

dshkol commented 4 years ago

Caching makes sense here too.

dshkol commented 4 years ago

Were you going to add this or do you want me to? You're the caching guy.

mountainMath commented 4 years ago

Pushed directly into the https://github.com/mountainMath/cansim/tree/precompile-vignette branch. I am getting CRAN check error related to the precompile vignette feature:

The following directory looks like a leftover from 'knitr':
     ‘figure’
   Please remove from your package.

Still leaning toward reverting back to the original way of doing things for now and not precompile the vignettes. Still thinking that somehow this gets taken care of automatically either by pkgdown or by some other way as long as we properly label them as vignettes.

dshkol commented 4 years ago

I think can just avoid that by adding figure$ to .Rbuildignore

mountainMath commented 3 years ago

I added the timeout variable in the https://github.com/mountainMath/cansim/tree/v0.3.6 branch.