search

mountainMath / cansim

Wrapper to access CANSIM data
Other
44 stars 5 forks source link

Call fails for Table 36-10-0108 with factors=TRUE #95

Closed mountainMath closed 3 years ago

mountainMath commented 3 years ago

The following call fails:

get_cansim("36-10-0108")

It works when conversion to factors is turned off.

get_cansim("36-10-0108",factors=FALSE)

This should be fixed by

  1. fail gracefully if factor conversion fails and emit a warning message only
  2. fix this so that it works with factors for this table too.
mountainMath commented 3 years ago

Fixed in https://github.com/mountainMath/cansim/pull/97

mountainMath commented 3 years ago

Similar problem occurs with table "36-10-0580".