Closed oisinq closed 2 years ago
Just noticed that my commit ended up adding some formatting that I didn't realise (I thought disabled eslint and prettier in my project, but I guess not?). Is there any standard codestyle/eslint config for the project? If not, is that something that we can set up? Just to keep future additions consistent.
Had a quick look over the code (don't have time right now to build and test), but it looks good and make more sense.
I've slowly been moving towards tabs (over spaces too), so I'm fine with that. Feel free to define some codestyle/eslint config.
Cool, no rush at all!
I just ran the code and noticed that it requires another dependency. I'm not really a fan of adding dependencies which are only used once (and for something pretty basic) - seems like overkill just to capture the space bar press event.
Also I'd like to move away from using Mixcloud's DOM elements and events (which can easily change) and try and capture the events on the "audio" controller as listed in the TO DO at https://github.com/mountainash/Mixcloud-Play/issues/26#issuecomment-609404195
Did you want to have a look into doing that instead?
Closes issue #33. Seems to work well in my testing.