search

mountetna / magma

Data server with friendly data loaders
GNU General Public License v2.0
5 stars 2 forks source link

Use old attr class names in json_template #136

Closed alimi closed 4 years ago

alimi commented 4 years ago

Since we've added new attribute classes, such as Magma::BooleanAttribute and Magma::LinkAttribute, Magma::Attribute#json_template has new values for attribute_class. This breaks the API for consumers like timur.

To keep the API consistent, we'll continue using the old attribute class names in #json_template.

This should get timur back to a working state without needing any changes. Since I'm newer to timur, I could use another set of eyes to verify things work 😄

graft commented 4 years ago

:+1: In the future we can add attribute_type to expose the magma type (integer/boolean/matrix, etc), make timur work with that, then phase this out.