search

mountetna / magma

Data server with friendly data loaders
GNU General Public License v2.0
5 stars 2 forks source link

Test fixes #174

Closed alimi closed 4 years ago

alimi commented 4 years ago

https://github.com/mountetna/magma/commit/f56a5c0406b7ba7ebaf178307d6403abcd11bd07 resets attributes that get changed in tests. Magma::Attribute#update_option changes options in memory that persist between test runs. As a result, attribute changes in UpdateModelController spec can cause other tests to fail. For example, prior to this commit rspec spec/server/update_model_spec.rb spec/magma_commands_spec.rb --seed 18642 would fail. Before we tackle the bigger challenges around global state, we can manually reset attributes that get changed.

https://github.com/mountetna/magma/commit/5fcbebab11292527cc723ef7424b9164898f3857 adds a new fixtures project called Movies that can be used to verify the behavior of projects with Ruby backed model definitions. This helps give us more confidence that production projects like Ipi that are still Ruby backed work.

graft commented 4 years ago

:+1: ship it quickly, before it becomes obsolete.