mountetna / monoetna

mono-repository version of etna projects
GNU General Public License v2.0
1 stars 0 forks source link

Gnomon - Batch Create and Browse MVPs #1267

Closed maflaven closed 10 months ago

maflaven commented 1 year ago

This adds Batch Create and Browse views to Gnomon.

To test:

  1. Rebuild etna-base and etna-base-dev images
  2. Spin up magma and gnomon

The create and browse tests and demo are probably the best place to start to get a sense of happy path behaviors.

image

A future release could allow adding multiple name types, opening up "OR" style queries as shown in the design.

image
dtm2451 commented 10 months ago

One bit from the demo today that you mentioned yourself, when a name already exists the error note currently refers to "already exists in magma", but should refer to in the "database" instead.

dtm2451 commented 10 months ago

Some quick testing went well for me just now after pulling the current code =)

Just one set of nitty new ideas regarding the grow / shrink buttons for both the create and browse pages that I think make their usage a bit more clear:

maflaven commented 10 months ago

Some quick testing went well for me just now after pulling the current code =)

Just one set of nitty new ideas regarding the grow / shrink buttons for both the create and browse pages that I think make their usage a bit more clear:

* perhaps the icons can be swapped for their horizontal form, as that's the direction more affected.  Not super important... I think MUI only has the one direction pre-baked.

* perhaps change the tooltip to "Show Button Labels" from the current "Grow"?

* perhaps change the label to "Shrink Buttons" or "Hide Button Labels" on the "Shrink" button?

I changed to "Show Labels" and "Hide Labels". Including "Button" would've made only that button have 3 lines of text, which makes all the other buttons a bit too big. Also rotated the icons 90° as suggested.