mountetna / monoetna

mono-repository version of etna projects
GNU General Public License v2.0
1 stars 0 forks source link

Add dittoDotPlot to Vulcan scViz workflow #1283

Closed dtm2451 closed 6 months ago

dtm2451 commented 7 months ago

This PR:

dtm2451 commented 7 months ago

I think this is ready for review!

To test:

  1. You'll need a project with an sc_seq_dataset model and an sc_seq_dataset to test with. Ping me for one, or use this dataset from xneo1 by recreating the record in a dev project. (OR you can have dev vulcan talk with production metis/magma, but I'm rusty about the details of that setup at the moment)
  2. Bring up at least janus, vulcan, edge-apache, metis, and magma.
    • TIME NOTE to be conscious of: This update requires the newest version of dittoSeq, and that required updating archimedes-r-base so bringing up vulcan will take a while, ~1hr. This time sync will unfortunately plague future re-builds of vulcan too if you try to bringing vulcan up afterwards on a branch without the updates from here.
  3. Create a scViz figure in vulcan, for that project, and select this dataset in the 'Object Selection' Primary Input.
  4. In the Set Plot Options step, choose 'dittoDotPlot' as plot type, then test away!
    • the new input is used in selection of 'Primary Data', but only for the 'dittoDotPlot' plot type

One note / limitation I'm feeling 'okay' with: In my opinion, the current form is usable but does feel a little clunky because feature selection is slower than ideal. I'd like to create some ways to fix the slow/clunk, but they're not small adds. Feel free to contradict or suggest alternatives, but these are my additional ideas for a future PR:

dtm2451 commented 6 months ago

Added icons to help, per @maflaven suggestion. 'DragHandle' icon within the reordering context, and the 'LowPriority' icon to help stress the presence of the reordering bit. (I don't think the mui 'Reorder' icon conveys the reordering idea very well, thus using the 'LowPriority' icon instead)

new-reorder-look

Also cleaned up most of the repeated code across the reorder_pieces & the 'DragHandle' icon is added to all of them. Tested :white_check_mark: these too.