Closed dtm2451 closed 6 months ago
I think this is ready for review!
To test:
archimedes-r-base
so bringing up vulcan will take a while, ~1hr. This time sync will unfortunately plague future re-builds of vulcan too if you try to bringing vulcan up afterwards on a branch without the updates from here.One note / limitation I'm feeling 'okay' with: In my opinion, the current form is usable but does feel a little clunky because feature selection is slower than ideal. I'd like to create some ways to fix the slow/clunk, but they're not small adds. Feel free to contradict or suggest alternatives, but these are my additional ideas for a future PR:
Added icons to help, per @maflaven suggestion. 'DragHandle' icon within the reordering context, and the 'LowPriority' icon to help stress the presence of the reordering bit. (I don't think the mui 'Reorder' icon conveys the reordering idea very well, thus using the 'LowPriority' icon instead)
Also cleaned up most of the repeated code across the reorder_pieces & the 'DragHandle' icon is added to all of them. Tested :white_check_mark: these too.
This PR:
SelectAutocompleteInput
andNestedSelectAutocompleteInput
inputs which make use of the mui Autocomplete'smultiple
option. The value output changes from string to string[] with this change, so though it easier to keep cleanly separated as new functions than to manage via an new input to the original functions. NamedSelectAutocompleteMultiPickInput
andNestedSelectAutocompleteMultiPickInput
.NestedSelectAutocompleteMultiPickInput
as a "piece" so could add to the VizUIReorderPiece
asReorderVizPiece
ReorderCollapsiblePiece
and implements that alongside the multi-pick piece asnestedDropdownMultiPickAndReorderPiece
.