search

mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

Graft fix json2csv #228

Closed graft closed 5 years ago

graft commented 5 years ago

There is a bug in production due to the npm package 'json2csv' having been upgraded from v3 to v4 in some indiscriminate package.json update. This PR fixes that big by updating the json2csv call.

It also adds a jest test for the timur 'downloadTSV' util function, which is used by 'VectorResult' and 'MatrixResult' in the ConsignmentResult to download a TSV of data. I'm not sure this is the best test to use.

eleanormark commented 5 years ago

I was able to successfully download tsv files from the Manifest and Search pages. Code implementation structure is fine.