mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

Graft fix browse slash #237

Closed graft closed 5 years ago

graft commented 5 years ago

This fixes two unrelated issues caused by the recent single-page client update.

The first was that using the 'browse' component to view records with a slash in the record_name route param was not working: magma would not recognize the record name because it was being sent with an encoded slash (%2F). This was fixed by decoding the path before making a request to magma.

The other was that the Link component, used to route any <a href/> clicks through the history API. This, however, failed on ordinary urls (e.g. 'https://github.com/') because the history API does not accept outside URLs. The component was amended to not push history events for such urls.