mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

Graft add error boundary #242

Closed graft closed 5 years ago

graft commented 5 years ago

Adding an error boundary around the plot on the plots page.

Because plots are still pretty unstable it is easy to generate a plot that crashes (that is, React cannot render it). Once you have saved such a plot, there is no way to edit it because: (1) you cannot goto /plot/your_broken_plot_id, because the page crashes and (2) you cannot go directly into edit mode.

This PR mitigates this issue by adding an error boundary to the plot page, a nice react feature that only blows up part of the DOM if a component crashes. You can then (hopefully) load your crashing plot page and go into edit mode to fix the problem.