search

mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

Fix select attribute bug, et al #246

Closed graft closed 5 years ago

graft commented 5 years ago

The SelectAttribute renders if the magma attribute in question has an array match for validation, i.e., valid entries are selected from that array. For whatever reason this seems to have become broken, i.e. the default value for the select attribute was not populating correctly. Instead it has been replaced with the better-made Dropdown component, which is much easier to control.

There is also a bunch of cleanup of the Attribute system in general, mostly refactoring the classes down to minimize number of lines.

Finally, a few random things: the client-side router has been separated out into its own module from the UI, and the 'description' field was missing on the plot model.

graft commented 5 years ago

Also: I removed the TSV download from the TableAttribute, rather than resolve a confusing coupling issue caused by the use of the "model view" component. In the future TSV download might be built directly into this view component.