mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

Graft fix display attributes #257

Closed graft closed 4 years ago

graft commented 4 years ago

A small bug leaked through into production because we did not keep timur up to speed with magma, and we eliminated the 'shown' key in the magma attribute template (which used to return !hidden, and has now been replaced by simply 'hidden'). This PR repairs that little issue, which resulted in the entire search results not showing up.

coleshaw commented 4 years ago

This works for me when testing locally. :+1: . Might be good to add a spec for this, at least a snapshot spec to make sure it renders? Not sure a spec would have caught this case of a changed attribute name though....probably need more integration-type tests on Staging for that.