search

mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

Magma-Metis Integration #259

Closed coleshaw closed 4 years ago

coleshaw commented 4 years ago

This is the Timur-end of the changes required for mountenta/magma#180.

Adds three new buttons for managing File and Image attributes:

Also updates the Image attribute to behave similarly as the File attribute component.

graft commented 4 years ago

One thing i noted yesterday in the demo: could you pop the metis path input out into a modal? The current behavior was kind of a placeholder when i handed it off and in the future we will probably want a larger file browser component there.

coleshaw commented 4 years ago

Re: modal, yup, I could do that.

I'm stuck trying to get the Magma gem to work with CI and bundle (also running into the same problem with monoetna). It would be helpful to switch to Etna Client or put Magma into RubyGems...so perhaps ignore the Ruby checks for now. Tests pass locally.

coleshaw commented 4 years ago

Changed to modal, it looks like this:

Screenshot from 2020-07-07 11-32-05

graft commented 4 years ago

The help in the modal is useful but maybe a bit aggressive for non-first-time users; could it go into the documentation repo + a small help link in the UI? Also looks like the modal breaks some styles...

coleshaw commented 4 years ago

Do you mean the input styles? Yeah, the modal lives outside of the attribute class tree, so I think we would have to re-create any of the styling that is missing.

So the documentation is already in this PR, mountetna/monoetna#12, so I can take out parts.

coleshaw commented 4 years ago

Screenshot from 2020-07-07 12-36-24

Modal has lost more weight.