search

mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

allow partial graphs to be drawn in model_map #267

Closed graft closed 4 years ago

graft commented 4 years ago

The new map breaks when models load into the store in the "wrong" order - if the store every has a graph state that is disconnected, it will be unable to render and the map will crash. Eventually the graph will be complete and can be drawn properly, but in the meanwhile the map should not crash. This PR we merely decline to draw a model until it is connected to the project graph; once all of the model objects make it into the store this should be fine.

coleshaw commented 4 years ago

This looks good to me and works when tested locally.

Small nit / comment: I find the order in which attributes are organized in ModelReport a little confusing, because it's not obvious that it's by type (with an un-specified type-order), and then alphabetical after certain types are set. Maybe something that every user will have different expectations for, but when I'm looking for a specific attribute I feel like I would scan alphabetically.