search

mountetna / timur

Data browser for biologists
GNU General Public License v2.0
3 stars 6 forks source link

Loading page directly on an assay record does not load data #276

Open coleshaw opened 4 years ago

coleshaw commented 4 years ago

For comet project, when I navigate through a patient record to assays, and then click on a specific assay record (i.e. cytokine), the data loads fine.

However, if you reload the page or navigate directly to the URL, the data does not load. This behavior seems inconsistent with the rest of the Timur app, where navigating directly to a URL usually works and the path to get to that data is transparent to the user. This only seems to happen at the assay level and not to the other models???

graft commented 4 years ago

This appears to be because the assay does not have a view built - if so, Timur will attempt to auto-generate a default view. This seems to not play well with the #tab_name fragment, which defaults to #default when there is no view.

If you load this: https://timur.ucsf.edu/mvir1/browse/cytokine/MVIR1-HS102-D0PL6-CTK1#default then no data loads, because Timur does not know which attributes to request for the non-existent tab named "default". If you load this: https://timur.ucsf.edu/mvir1/browse/cytokine/MVIR1-HS102-D0PL6-CTK1 Timur correctly requests the entire record, then redirects to #default.

coleshaw commented 4 years ago

Oh, now that's interesting, I didn't realize it had to do with the #default tab view. Thanks, that helps pinpoint this!