Closed mourner closed 5 years ago
Looks good to me @mourner. It sounds like you may be intending to publish multiple main entry points in the same package (ES Module & UMD) – which is nice to be able to do for single-module packages.
I'd be happy to contribute if there are more todos and to test it out if you publish a beta.
Sounds good to me @mourner
Since #89 warrants a semver-major release, I thought I'd cram some more breaking changes that I'd like to do at the same time. So far the PR:
rbush(...)
tonew RBush(...)
, a more idiomatic ES approach — since ES forbids calling classes withoutnew
, and we still want to expose an extendable class rather than a factory.format
option. While convenient, it still doesn't feel good to rely on eval while developers increasingly adopt strict CSP rules. If we remove it, we'll just document dealing with custom formats by redefiningtoBBox
,compareMinX
andcompareMinY
methods.To do:
format
option?cc @rowanwins @tschaub thoughts?