mourner / suncalc

A tiny JavaScript library for calculating sun/moon positions and phases.
BSD 2-Clause "Simplified" License
3.07k stars 412 forks source link

nadir is past but it should be in future! #124

Open andiling opened 5 years ago

andiling commented 5 years ago

Nadir should be in the future not in past! Please fix it!

frankjoke commented 5 years ago

I raised this issue already a 1-2 years ago! Maybe it's not in all time zones but it comes because for base calculation he subtracts 0.5 days from current day to have noon and another 0.5 days for nadir which mean that he use previous day (at lease for all time zones with GMT+x).

ATouhou commented 5 years ago

+1