Add support for Monks Enhanced Journal

[jfrazierjr]

Add my vote for working with Monk to add support for Enhanced Journal. Monks module is exceedingly useful addition to the core foundry and your UI appears to be an amazing nice skin.

[mouse0270]

The problem is that I really like the look and feel of journals in v10. I think foundry did a fantastic job. I think ironmonk Enhanced Journal adds a lot of neat features, but from what I could quickly see, that module doesn't use the new v10 template.

So the problem is, I am OCD and spent a lot of time getting this UI to feel just right and for me to do that with Monks Enhanced Journal, that will require a lot of work, as I'd like to update the template and code to be more in line with foundrys v10 journal template.

Its something I the idea plate, but I you shouldn't get your hopes up. I might hope into the code to make the interface a little less clashy, but a complete rewrite to make there journal look stunning, is going to be A LOT of work.

[jfrazierjr]

Trust me, I totally get it(I am a software dev, but back end stuff with only a small amount of experience with js/html/css and that is 10 years out of date or so). I would still suggest reaching out to IronMonk. There is a chance that he is still working on his Journal.

I SUSPECT he did the "get it working" and THEN "get it working with the new changes foundry put into V10" is one of those in progress things as his time permits(but don't know that for sure!). As well, if he is willing to do a collab, it might make it easier on both to split some of the work as long as it remains compatible with other UI mods as well. Anyway, just a quick look at his github make it appear that he might be working on both bug fixes as well as possibly upgrades post v10, so im crossing my fingers.

Anyway, thanks for considering this. I have yet to upgrade to V10 and only briefly looked into the new Journal features. I would LOVE to have both merged, but honestly, I don't know if I could easily ditch Monk's concept of breaking Journals up into discreet "things". On the flip side, (I am using the D&D theme mod right now), I REALLY love the styling of the mod you have done.

Either way, thanks for the amazing work, even if you don't end up moving forward with Monk support.

[mouse0270]

I'll have to reach out to them and see what their plans are. If they plan to update the UI to better match v10 Journals, then I really wouldn't want to put any work into it until they have done that, Otherwise there is a good chance that were just going to clash again when its updated.

Technically the two modules do work perfectly fine together, its just Monks Enhanced Journal doesn't look as good as the default journals. For example, here is a screenshot with v10 Journals (left) and Monks (right). His journals do work within my theme, its just they are very cluttered in my opinion.

So its not that you can't use their journal module, its just not up to my level of UI. No shame to iron monk or anything, because their journal module is fantastic and has a lot of amazing features, but even the default layout in v10 feels very cluttered is claustrophobic.

I do know its popular and I do want to theme it if I can. But its more of a when I can then a I feel like I have to thing.

[jfrazierjr]

Just for comparison, here is a fully native "Monk's Journal" with your UI:

It seems to support the main area using your styling, but the sidebar is not themed.

and here it is again, with the sidebar removed(using Custom CSS):

div.directory-sidebar { display: none; }

which looks halfway decent as is. Don't get me wrong, I REALLY like the custom sidebar as it makes it super easy when using Popout, but I could live with it not being there if worse came to worse.

and yea, I get what you mean about the theming when using the v10 version of Journals after doing a bit of testing. It's a bit hard to remember, but i think in v9, Monk had a "generic" Journal entry which is what the default styling(other than some extensions to the text editing control IIRC) seems to be going back to in your example above, so it might be fairly easy for Monk to do some quick checks and not style any of the default Journal pages(ie, those in the Adventure Journal "group" added in v10) to let your and any other UI mod do that styling. I am also going to open an issue over on his github as well.

Also, one other item to note, the sidebar with the Journal structure is collapsible and neatly hides itself(I just found this out!) so might be easy to set into the default state of hidden.

[mouse0270]

So here is my attempt to improve on Monks Enhanced Journals. I can't say its going to get much better than this, but here is what I've come up with so far.

[jfrazierjr]

thanks! I think it looks pretty cool. Can I assume that the js error is also fix or at least caught and ignored?

Looking forward to the update. and ill plan to figure out how to get paypal working soon to get you a kofi dono for all your hard work and great mods.

[mouse0270]

Basic support has been added in version 0.4.0. However I am leaving this issue as open as I'd like to make more improvements on the UI.

v0.4.0 https://github.com/mouse0270/fantasy-rpg-ui/releases/tag/0.4.0