search

mouse0270 / fantasy-rpg-ui

Other
6 stars 1 forks source link

Turn Off Style Option for Actor Sheet #7

Closed brunocalado closed 1 year ago

brunocalado commented 1 year ago

Hi!

Savage pafthinder makes heavy style changes. Is it possible to add an option to turn off style modification for actors?

UI Off image

I loose all buttons when the UI is on... :(

UI On image

mouse0270 commented 1 year ago

Do you want me to disable the theme for actor sheets or fix the header buttons being hidden? Cause honestly the ui basically works minus the buttons being hidden cause of an overflow property

brunocalado commented 1 year ago

Do you want me to disable the theme for actor sheets or fix the header buttons being hidden? Cause honestly the ui basically works minus the buttons being hidden cause of an overflow property

What is easier. I fear all changes from the swpf + ui give some trouble. Maybe disable for the actor sheet.

JacobSeibel commented 1 year ago

I'll second that I'd like to be able to disable the theme altogether for actor sheets via a setting. I use Tidy5e Character Sheets, and I'd love to continue using the theme everywhere else until support is added for Tidy5e.

mouse0270 commented 1 year ago

Alright, I can pull actor sheets out so they can be abled separately from everything else. I get that update out today.

mouse0270 commented 1 year ago

Can you link me the module or system that is creating this Actor Sheet. I can't seem to find it.

brunocalado commented 1 year ago

Can you link me the module or system that is creating this Actor Sheet. I can't seem to find it.

It's a premium (paid) module...

What do you need?

mouse0270 commented 1 year ago

Would you be able to test this release and let me know if it resolves the issues for all of your open tickets?

https://github.com/mouse0270/fantasy-rpg-ui/releases/download/0.3.7b/module.json

brunocalado commented 1 year ago

small time ok https://user-images.githubusercontent.com/4999783/196013520-809c7901-7bb1-4b6f-8256-c7fc9468b27d.mp4

better rolls 2 nok image

quest log ok image

actor sheet nok image

custom logo couldn't find option

mouse0270 commented 1 year ago

you might have to enable the module in the theme. I might have forgot to add them to the update logic.

brunocalado commented 1 year ago

you might have to enable the module in the theme. I might have forgot to add them to the update logic.

image What should I do?

mouse0270 commented 1 year ago

In the sidebar, click on Configure Theme then Go to Fantasy RPG UI and make sure those modules are enabled. image

I just noticed I forgot localization for Better Rolls

brunocalado commented 1 year ago

quest log ok image

mouse0270 commented 1 year ago

Is Better Rolls broken still?

brunocalado commented 1 year ago

actor sheet buttons are invisible, but show on mouse over https://user-images.githubusercontent.com/4999783/196013798-55301fee-38af-4ae6-89fe-96550af751a4.mp4

better rolls 2 image

mouse0270 commented 1 year ago

The actor sheet is a bug with libThemer. If you click on the arrow next to Enable Theme for Actor Windows you should be able to uncheck the Hide Header Buttons

This is something I need to fix in libThemer that if you disable a top level checkbox, it should disable all the ones below it.

Do you have any errors? It seems to be working for me, so I am not sure whats going on for you.

brunocalado commented 1 year ago

Nice! image

Everything ok.

brunocalado commented 1 year ago

I don't know if this means something image

mouse0270 commented 1 year ago

Alright, I am going to switch over to the better rolls issue to continue this. Because it appears this specific issue will be resolved

mouse0270 commented 1 year ago

Should be resolved in version 0.3.7.1