mouse0270 / lib-themer

A library used to create css variables for use in themes
MIT License
3 stars 2 forks source link

[Feature Request] Better Loading of Themes #24

Open ducky00 opened 1 year ago

ducky00 commented 1 year ago

Hey dude, I've been using this module for a while now and it's amazing, really love it. However there's one little thing that bothers me a bit, don't even know if this could be called a feature request, but doesn't feel like a bug either. When I first load my world it takes a few seconds for the theme to pop in and replace the standard one resulting in a very annoying lagging - which doesn't last long - my worry is that some lower end machines of my players won't handle this very well and might crash the browser. Is there anyway this issue could be optimized?

mouse0270 commented 1 year ago

So there really isn't a good solution to this, because it basically won't initialize until Foundry is ready, which is after already loading the UI.

Technically I could hide the UI until Foundry is ready, but that causes issues if something crashes, you basically could get stuck and never be able to use the UI.

As for lower-end machines, this should never cause them to crash, but it can mean it would take longer for the theme to load. Trust me with the release of my Fantasy RPG UI, I've put some thought into making this transition smoother, but I haven't really thought of a smoother way.

If the main concern is crashing, that shouldn't be an issue and if it is crashing your players, please let me know, cause that is a bug. As for now, I currently really don't have a good solution to make the transition smoother.

Though please know, I've got a few idea's I want to try so I am not saying I don't plan to make improvements, I am just not sure if any of them will work without putting more stress on either the GM or players' side.