search

mouse0270 / lib-themer

A library used to create css variables for use in themes
MIT License
3 stars 2 forks source link

Trusted Players are not affected by GM Theme option #35

Open ducky00 opened 1 year ago

ducky00 commented 1 year ago

I just realized that users with the trusted player level of permission are not affected by the GM Theme option. Well, from what I saw they are, but not in all aspects, so the UI looks very strange and unreadable.

Maybe an option to enable the GM theme just for certain roles could enhance that?

ducky00 commented 1 year ago

gonna use this thread to say that my GM theme option, actually, does not enable the theme for any user at all, I wonder if I'm doing something wrong or it's just a bug

mouse0270 commented 1 year ago

Is there any errors in the console?

If your player is logged in does it change the setting when you change a setting? I made a change in the last update that I only pass in the most recent update and not all of them. However it should sync when they login to the current theme.

Can you send me a photo of your settings for libThemer

ducky00 commented 1 year ago

Only these errors/warnings related to lib-themer image

The only thing I noticed in that regard is that when I disable the GM Theme option, the player user can see the button to configure a theme (in the settings tab), aside from that I didn't notice anything of the sort

My settings as requested: image

mouse0270 commented 1 year ago

Alright, so it looks like the variable array that should be storing the theme isn't an array and is causing the .concat function of the array to break. It also appears that is an issue with my localization repeating over and over for you. Thats gotta be annoying, is that only libThemer doing that for you, where the hint text is repeated like that?

ducky00 commented 1 year ago

No no, I guess it's a bug from another module, a refresh solves it, so it's fine

ducky00 commented 1 year ago

So this array breaking is something I would need to solve on my end?

mouse0270 commented 1 year ago

Its a bug, I am not sure what caused it, I think I have an idea how to fix it but I want to test it before I just tell you to make sure I don't break more things.

niuserre commented 1 year ago

gonna use this thread to say that my GM theme option, actually, does not enable the theme for any user at all, I wonder if I'm doing something wrong or it's just a bug

Just wanted to mention that it is working for me on both a Player and a Trusted Player. After checking 'Enable GM Theme' I had to relog both the GM and the player to get it to work (initially I just did the player but that wasn't enough), but it does work as expected.

I am not using the custom theme directory, I just used the Manage Presets thing.

Here is my module list of things that are working fine with it in case it's a conflict (DnD5e system). 2022-12-30-package-list.txt