search

mouse0270 / lib-themer

A library used to create css variables for use in themes
MIT License
3 stars 2 forks source link

Closing the Theming Menu resets settings to defaults. #5

Closed XtraButtery closed 1 year ago

XtraButtery commented 2 years ago

Closing the Theming Menu using the close button in the titlebar resets the theme to Core Foundry Theme rather than cancelling any changes and returning to the previously configured setting. This occurs even when a preset theme (such as Cobalt) is selected.

mouse0270 commented 2 years ago

I actually know about this one, I will look into seeing what I can do to resolve it.

XtraButtery commented 2 years ago

I was messing around with the code for Custom Nameplates and managed to introduce a similar glitch before by removing some lines of code in the nameplate-config.html file.

I gave up on the project fairly quickly as I realised it was above my level of complexity fairly early on, but the code seemed relatively simple. Looking at it might be able to help you figure out the sorts of calls that are available to fix the issue.

Alternatively Whetstone, which is a similar module to yours, manages this and was published under the MIT license, so in the best case scenario you may even be able to lift/borrow code directly from the project to resolve your issue.

XtraButtery commented 2 years ago

I actually did some further testing of this earlier, it appears that it doesn't actually revert to the default setting at all, but rather it resets to whatever theme was set when the server was launched.

Perhaps simply refreshing the browser/window when a new setting is saved would resolve this bug as it doing so also seems to fix issue #4

Many other modules do this when important settings are changed and it seems to be a relatively quick and easy fix for two issues.

mouse0270 commented 1 year ago

Fixed in v0.1.0b for Foundry v10.

Current beta found: https://github.com/mouse0270/lib-themer/releases/download/0.1.0b/module.json