search

mouse0270 / lib-themer

A library used to create css variables for use in themes
MIT License
3 stars 2 forks source link

Twilight UI Preset remains even after Twilight UI is uninstalled. #8

Closed XtraButtery closed 1 year ago

XtraButtery commented 2 years ago

If the Twilight UI Preset was set when the Twilight UI module is uninstalled it will remain in the list even after it is deselected and the game is restarted. image

mouse0270 commented 2 years ago

This might be fixed in a new version I have updated. I will double check.

The problem is I was using foundrys mergeObject function for this and while, it is bugged and doesn't work with blank objects and always merges them. So it was keeping ghost elements.

I reported this and rewrote it, but I am not sure if I have pushed that version. I recently had a major life event upset my time and really just getting back into everything as of a week ago.

I will verify this and see if I can push out the udpated code that should handle this but no real promises until I can look at it later today or tomorrow.

XtraButtery commented 2 years ago

Sorry to hear about your personal issues, I wish you all the best.

Despite my massive influx of bug reports, I'm a real big fan of the module and what it does. If you'd like any help testing out new code or features at any point, feel free to let me know as I've honestly had a lot of fun trying to uncover all the various issues lately.

mouse0270 commented 2 years ago

Life happens and its not always great. Thank you for your kind words.

No no no, I've been waiting for a big list of bugs, Its kinda hard as someone who uses foundry for my very basic needs to know what this module breaks on. I really dont use more then like 20% of what foundry has to offer (I recently learned it can do camera's and VC). So I need lots of bug reports to be able to fix things. Thank you for taking your time to break this module, I do appricate it.

mouse0270 commented 1 year ago

Closing this as I don't believe this is valid for the current implementation of libThemer.