search

mouse0270 / module-credits

Lists the authors of projects on the Manage Modules Window. If a url is provided in the module.json file, it will make the version tag link to the module url.
MIT License
7 stars 7 forks source link

V11 fixes #100

Closed kristianserrano closed 1 year ago

kristianserrano commented 1 year ago

Adds some fixes for v11 compatibility. Closes #98 .

(Sorry for the whitespace trims.)

mouse0270 commented 1 year ago

I was unable to make this pull request due to how I implemented the title selector.

I also forgot to include a credit to you for pointing out and fixing this, however, I have already included it and fixed the changelog so it will be visible in the next release. I apologize for this oversight.

kristianserrano commented 1 year ago

It's all good. Just happy to have helped in whatever way I could. :)

mouse0270 commented 1 year ago

I also haven't updated it to include the recommends option. I need to think on that more, because in my personal recommends isn't really a good term.

It implies that I recommend that module, where in reality, I might just provide support for that module, meaning its optional instead of recommend. So I need to figure out how I want to support this as, I believe foundry and I have different opinions of how that type of relationship should work.

kristianserrano commented 1 year ago

Ah, if it's just "supports" and not "it works better with...", then I wouldn't even list it.

mouse0270 commented 1 year ago

Thats the difference between recommends and optional, a current discussion I am having with VTT devs