mouse0270 / module-credits

Lists the authors of projects on the Manage Modules Window. If a url is provided in the module.json file, it will make the version tag link to the module url.
MIT License
7 stars 7 forks source link

Credits pop up every time the world loads #8

Closed dmrickey closed 2 years ago

dmrickey commented 3 years ago

https://youtu.be/w-K7YfamPtY

The credits always pop up instead of just when a module is updated. If I continuously hit refresh you can see that it just keeps popping up.

mouse0270 commented 3 years ago

That is because there is unread change logs. I should make that more clear. If you click on all of them so they have an open eye and refresh does it still do that?

On Sat, Oct 23, 2021, 10:43 AM dmrickey @.***> wrote:

https://youtu.be/w-K7YfamPtY

The credits always pop up instead of just when a module is updated. If I continuously hit refresh you can see that it just keeps popping up.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mouse0270/module-credits/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEJ5CTI5Q5HQJR7WZQ753TUILCZHANCNFSM5GSK7MLA .

dmrickey commented 3 years ago

"all"? As far as I can tell there's only one thing that's unread because there's only one thing on the list that has an open eye icon.

mouse0270 commented 3 years ago

Open eye means you've read it, eye with a slash means you have not read it.

On Sun, Oct 24, 2021, 5:13 AM dmrickey @.***> wrote:

"all"? As far as I can tell there's only one thing that's unread because there's only one thing on the list that has an open eye icon.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mouse0270/module-credits/issues/8#issuecomment-950289291, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEJ5CXNVAAE2YVYIPMQYZDUIPE4PANCNFSM5GSK7MLA .

mouse0270 commented 3 years ago

If you noticed each time you refreshed you had one less item on the list. Basically just go through and click them all so they eye changes to an eye with no slash

dmrickey commented 3 years ago

Ah, I had the iconography backwards. I thought the eye with the slash meant I no longer needed to see it and that the rest were there as a history of things that have already changed

mouse0270 commented 3 years ago

Its all good.

Once you click on them all, they'll go away.

On Sun, Oct 24, 2021 at 8:08 PM dmrickey @.***> wrote:

Ah, I had the iconography backwards. I thought the eye with the slash meant I no longer needed to see it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mouse0270/module-credits/issues/8#issuecomment-950422765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEJ5CRWBNKUMZU7PJN4EMDUISNWPANCNFSM5GSK7MLA .

dmrickey commented 3 years ago

Yup, it's all good now. Sorry for the misunderstanding.