search

mouse07410 / asn1c

The ASN.1 Compiler
http://lionet.info/asn1c/
BSD 2-Clause "Simplified" License
94 stars 70 forks source link

Validate enumerations. #121

Open bknotwell opened 1 year ago

bknotwell commented 1 year ago

I'm not a fan of the way I threaded state through with the localvalidation member but I don't have a better idea. I added it as a union to make it easier to reuse it for other use cases.

bknotwell commented 1 year ago

I considered adding a way to turn this off as working validation might surprise people but decided against it.

mouse07410 commented 1 year ago

@bknotwell could you please take a look at why the CI fails, and (hopefully) remedy it? Thanks!

mouse07410 commented 1 year ago

@bknotwell ping?

mouse07410 commented 1 year ago

@bknotwell thank you for the contribution - but are you planning to fix the CI failures?

mouse07410 commented 1 year ago

I considered adding a way to turn this off as working validation might surprise people but decided against it.

@bknotwell i can't afford merging a PR that breaks validation. Could you fix it, please?