Closed BoskyWSMFN closed 5 months ago
I wonder why the CI fails (file skeletons/INTEGER.c
line 367, pend1 += add
part). Any idea?
Honestly no. I didn't even modify INTEGER.c
. There's some smart endianness check in that function what can potentially cause out of bounds problem. I'll try to deal with this on the weekend.
@BoskyWSMFN could you please rebase your PR against the current vlm_master? It might help...
Oh... Sorry for the details, but I was already asleep. It looks like you managed everything without me. =)
@mouse07410, and the CI fails again. May be I'll rebase my PR after all?
Thank you fur your contribution. I doubt it's worth rebasing now - GitHub did it on its own during the merge.
If you could - please check the CI on the vlm_master branch, and try to figure how to address:
skeletons/INTEGER.c
line 367, where the pointer needs incrementing;tests/tests-skeletons/check-INTEGER.c
where GitHub CI wants %ld
, and my compilers want %lld
. Is there an option or a value that would allow "peaceful" compilation by both CI and my local compilers?I could but on the weekend. Wait for a new PR. =)
Thanks! Yes please. BTW, the already-merged PR passes CI, add you can see in the GitHub Actions for this repo.
So, welcome as a new contributor - and feel free to offer more improvements. For example, there are more warnings about format mismatch, as you can see in the CI report (but as I said, I had to make those to address competition warnings on my system, so the solution can't be just reverting then from %lld
back to %ld
and such).