Closed spfoos closed 2 years ago
mouse07410
commented
2 years ago @spfoos I really appreciate the effort to add JER support to ASN1C. But I can't merge a PR that doesn't pass the existing tests.
I realize this is a big effort, and requires time. Hopefully,as time goes, you'll be able to make this PR more complete?
mouse07410
commented
2 years ago @spfoos could you please take a look at https://github.com/mouse07410/asn1c/runs/5337204846?check_suite_focus=true and consider fixing that? Thanks!
spfoos
commented
2 years ago @mouse07410 I have resolved all tests except 3. 2 in tests-c-compiler 1 in tests-randomize
I help trying to figure out the solution to these tests. It seems unrelated to the code changes I introduced (JER), whereas the tests are failing in XER and APER.
spfoos
commented
2 years ago @mouse07410 As you can see the checks are passing. Can this PR be merged?
mouse07410
commented
2 years ago As you can see the checks are passing. Can this PR be merged?
Good point. Merged, thank you!
A few questions about the direction this enhancement will take.
Creating a PR to start a discussion on how to proceed further. Any inputs welcome. Currently, the scope is only encoding to JSON, not decoding from JSON. Not all types are supported.
Needless to say, I'd like to see JSON decoding as well. And, support of all allowed types.
Are you planning to work on that? I hope the answer is yes. ;-)
make check fails.
Thankfully, not anymore. Good job!
TODO: Write tests. XER tests are weak, and only supports decoding tests.
Yes. More tests would be welcome.
mouse07410
commented
2 years ago @spfoos any plans to continue JER implementation?
Creating a PR to start a discussion on how to proceed further. Any inputs welcome.
Currently, the scope is only encoding to JSON, not decoding from JSON. Not all types are supported.
make check fails.
TODO: Write tests. XER tests are weak, and only supports decoding tests.