search

mouse0w0 / forge-mixin-example

An example for using Mixin in Minecraft Forge 1.12.2 & 1.8.9
The Unlicense
113 stars 19 forks source link

mcmod.info: fix typo #14

Closed rust2 closed 2 years ago

mouse0w0 commented 2 years ago

authorList must be JSON array. Although the old one is illegal JSON syntax, it can process the author list. If you want to modify the author list, modify the mod_author property in gradle.properties.

rust2 commented 2 years ago

Made a typo while trying to fix a typo. Sorry. But this mcmod.info is not a valid JSON:

[04:16:18] [Client thread/ERROR] [FML]: The mcmod.info file in main cannot be parsed as valid JSON. It will be ignored
com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Unterminated object at line 10 column 19 path $[0].authorList
    at com.google.gson.internal.Streams.parse(Streams.java:60) ~[Streams.class:?]
    at com.google.gson.JsonParser.parse(JsonParser.java:84) ~[JsonParser.class:?]
    at com.google.gson.JsonParser.parse(JsonParser.java:59) ~[JsonParser.class:?]
    at net.minecraftforge.fml.common.MetadataCollection.from(MetadataCollection.java:63) [MetadataCollection.class:?]
    at net.minecraftforge.fml.common.discovery.DirectoryDiscoverer.exploreFileSystem(DirectoryDiscoverer.java:80) [DirectoryDiscoverer.class:?]
    at net.minecraftforge.fml.common.discovery.DirectoryDiscoverer.discover(DirectoryDiscoverer.java:62) [DirectoryDiscoverer.class:?]
    at net.minecraftforge.fml.common.discovery.ContainerType.findMods(ContainerType.java:47) [ContainerType.class:?]
    at net.minecraftforge.fml.common.discovery.ModCandidate.explore(ModCandidate.java:74) [ModCandidate.class:?]
    at net.minecraftforge.fml.common.discovery.ModDiscoverer.identifyMods(ModDiscoverer.java:93) [ModDiscoverer.class:?]
    at net.minecraftforge.fml.common.Loader.identifyMods(Loader.java:427) [Loader.class:?]
    at net.minecraftforge.fml.common.Loader.loadMods(Loader.java:568) [Loader.class:?]
    at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:232) [FMLClientHandler.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:467) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:378) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_312]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_312]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_312]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_312]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_312]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_312]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_312]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_312]
    at net.minecraftforge.legacydev.Main.start(Main.java:86) [legacydev-0.2.3.1-fatjar.jar:0.2.3.1+4+372be23]
    at net.minecraftforge.legacydev.MainClient.main(MainClient.java:29) [legacydev-0.2.3.1-fatjar.jar:0.2.3.1+4+372be23]
Caused by: com.google.gson.stream.MalformedJsonException: Unterminated object at line 10 column 19 path $[0].authorList
    at com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1559) ~[JsonReader.class:?]
    at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:491) ~[JsonReader.class:?]
    at com.google.gson.stream.JsonReader.hasNext(JsonReader.java:414) ~[JsonReader.class:?]
    at com.google.gson.internal.bind.TypeAdapters$29.read(TypeAdapters.java:738) ~[TypeAdapters$29.class:?]
    at com.google.gson.internal.bind.TypeAdapters$29.read(TypeAdapters.java:731) ~[TypeAdapters$29.class:?]
    at com.google.gson.internal.bind.TypeAdapters$29.read(TypeAdapters.java:714) ~[TypeAdapters$29.class:?]
    at com.google.gson.internal.Streams.parse(Streams.java:48) ~[Streams.class:?]
    ... 26 more
rust2 commented 2 years ago

Or this only works on final builds with gradle?

mouse0w0 commented 2 years ago

I have no idea to fix it. If you have ideas, welcome to contribute.