search

mouseas / steamSummerMinigame

Steam Summer Sale 2015 - Auto-play Optimizer
MIT License
136 stars 189 forks source link

Add Steal Health and only use it if medic is not active. #55

Closed drantor closed 9 years ago

drantor commented 9 years ago

Only use god mode if no other heal skill is running and fix isAbilityActive.

mouseas commented 9 years ago

The logic doesn't look right. It should use Medics if it's available regardless of availability of Steal Health or God Mode. If Medics is not available but Steal Health is, and Medics is not active in the lane, then Steal Health should be used. If neither Medics nor Steal Health is available, and neither is currently active in the lane, then God Mode should be used.

drantor commented 9 years ago

Okay should be fine now.

  1. Always use Medic
  2. Use Steal Health when Medic is not active on current line
  3. Use God Mode when neither Medic nor Steal Health is active on current line

Still have to test but they went into server maintenance

mouseas commented 9 years ago

I need 1 person to independently test this for errors and functionality.

winneon commented 9 years ago

There are merge conflicts in this pull request due to the filename change. Ignore them. I'll resolve them when the time has come for this to be merged with the master branch.

JCKE commented 9 years ago

I believe this can be closed, as the features have been implemented elsewhere

ZedTheYeti commented 9 years ago

Alright, closing.