mousebat / QsirchMac

A MacOS app for searching QNAP Devices
MIT License
6 stars 0 forks source link

Interface issues #1

Open lakemike opened 3 years ago

lakemike commented 3 years ago

Hi mousebat, First of all, congrats for doing a great job! I did not get any Finder/Spotlight integration with QSirch done and I am not a great fan of QNAP's web interface, so this is a great option to have!

Search works very well over here or at least results look fine in first tests. I use a port other than 443, great to have this option!

Some interface issues (see screenshot):

95113864-62663200-0743-11eb-83fb-9437fb2feb05

PS: Have donated a couple of pints 🍻 🍸 🍷

PPS: I should probably also mention my system: I'm on a Macbook pro 2019 model, latest Catalina 10.15.7, retina screens.

mousebat commented 3 years ago

Hi mate!

Thank you for the donation 🤗 I’ll have a go at fixing the issues tomorrow. The gear icon is an easy fix, I was rushing to get the app packaged. The umlaut and accent character situation is probably to do with the url encoding for the GET request so should be straightforward enough to sort. I’ll also try and sort the window resize issue - it definitely shouldn’t do that 😂.

All the best 👍🏻

mousebat commented 3 years ago

I've fixed the icon issues apart from the sort direction, doing that in a minute. I've also notarised the app with Apple so Gatekeeper won't throw it's toys out of the pram.

lakemike commented 3 years ago

I've fixed the icon issues apart from the sort direction, doing that in a minute. I've also notarised the app with Apple so Gatekeeper won't throw it's toys out of the pram.

Indeed, both icons appeared ;)

mousebat commented 3 years ago

I've had to remove the icons from the sort direction drop down. They were put in as just text symbols but it does require SF font to be installed and not everyone has that. I'm uploading this now. When I do develop the app for Big Sur I'll be able to add these in as SwiftUI is quite limited for Mac OS on Catalina.

lakemike commented 3 years ago

I think text symbols are fine. Am wondering if the logic behind the pull-downs could be more intuitive, i.e. when I select "sort" - will that be ascending or descending and why would there be 3 choices?