mousebird-consulting-inc / WhirlyGlobe

WhirlyGlobe Development
Other
828 stars 255 forks source link

changeVectors #118

Closed rghosh0 closed 10 years ago

rghosh0 commented 10 years ago

Hi, it seems to me that MaplyBaseViewController changeVector:desc: is no longer working. I have a patch to the ComponentTester, which seems to work for an older version (Oct 25) but not recent versions.

https://s3.amazonaws.com/arcturus/changevectortest.diff

I made the countries filled, with red, and added a toggle item after Countries that changes their colors to blue. It seems to work for an old version in the develop branch but not newer versions.

Working:

b6d2b37fc6 (Oct 28)

Not working (countries stay red):

345f176726 (Dec 13) b363497849 (Jan 24)

rghosh0 commented 10 years ago

Hi, I notice that this problem has gone away quite recently. I believe the codebase from February 10th still had this problem, but I just updated and the problem's gone. Thanks!

For the record I believe change 5d8c83fce2 (Nov 13) is when the problem was introduced.

mousebird commented 10 years ago

That makes sense, actually. Glad to know it's fixed. Thanks.