mousebird-consulting-inc / WhirlyGlobe

WhirlyGlobe Development
Other
830 stars 255 forks source link

ABI x86_64 #1558

Open BLoeT opened 2 years ago

BLoeT commented 2 years ago

Could you provide a jni x86_64 version for your lib? I used the latest .aar

I tried to build my app on an x86_64 device and it brings this error:

Cannot build selected target ABI: x86_64 or there are no .so files available to package in the apk for x86_64

In the aar are x86, arm64-v8a and armeabi-v7a.

Or could you pls give me a hint what I can do ?

sjg-wdw commented 2 years ago

Hey @TimSylvester are we still building for x86?

TimSylvester commented 2 years ago

I vaguely recall experimenting with that at some point, but not why it isn't currently included. It seems to build fine, so it's probably just that most devices are ARM-based.

I believe you would just need to add x86_64 to the build.gradle:

                ndk {
                    abiFilters 'arm64-v8a', 'armeabi-v7a', 'x86', 'x86_64'

...

[523/523] Linking CXX shared library ../../../../build/intermediates/cmake/debug/obj/x86_64/libwhirlyglobemaply.so

BLoeT commented 2 years ago

I just use the aar file from your website: http://mousebird-consulting-inc.github.io/WhirlyGlobe/builds/builds.html

Description how to add the aar file from here: http://mousebird-consulting-inc.github.io/WhirlyGlobe/tutorial/android/building-from-binary.html

I included the aar file like this Kotlin: implementation(group="libs",name="WhirlyGlobeMaply", ext="aar")

with this i got errors like in my first post.

I tried to use abiFilters but no success. In the aar are only the three jni versions

TimSylvester commented 2 years ago

Here's one I just built from develop with x86_64 added. Unfortunately, the automated CI build has been broken for a while and isn't getting any love.

maply_release.zip

If you update the gradle file, you can build this from Android Studio by running the assembleRelease task in the Gradle panel, after which you'll find it in .../android/library/maply/build/outputs/aar.

BLoeT commented 2 years ago

Thank you very much

I'll give it a try.


From: Tim Sylvester @.> Sent: Thursday, September 22, 2022 1:16:33 AM To: mousebird-consulting-inc/WhirlyGlobe @.> Cc: Enrico @.>; Author @.> Subject: Re: [mousebird-consulting-inc/WhirlyGlobe] ABI x86_64 (Issue #1558)

Here's one I just built from develop with x86_64 added. Unfortunately, the automated CI build has been broken for a while and isn't getting any love.

maply_release.ziphttps://github.com/mousebird-consulting-inc/WhirlyGlobe/files/9620902/maply_release.zip

If you update the gradle file, you can build this from Android Studio by running the assembleRelease task in the Gradle panel, after which you'll find it in .../android/library/maply/build/outputs/aar.

— Reply to this email directly, view it on GitHubhttps://github.com/mousebird-consulting-inc/WhirlyGlobe/issues/1558#issuecomment-1254327206, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AASQGS4UEWEDZRFRBWHK5EDV7OJNDANCNFSM6AAAAAAQPMOEBA. You are receiving this because you authored the thread.Message ID: @.***>

tonsdean commented 2 months ago

any updates with this issue Sir Tim?

TimSylvester commented 2 months ago

Nothing new, no.