search

moust / cordova-plugin-videoplayer

A Codova plugin to play video with the native MediaPlayer on Android devices.
MIT License
139 stars 102 forks source link

Pull-request #70 breaks build for application that target older Android version #71

Open vo-va opened 3 years ago

vo-va commented 3 years ago 
<path_to_ionic_project>/platforms/android/app/src/main/java/com/moust/cordova/videoplayer/VideoPlayer.java:123: error: cannot find symbol
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
                                                        ^
  symbol:   variable R
  location: class VERSION_CODES
<path_to_ionic_project>/platforms/android/app/src/main/java/com/moust/cordova/videoplayer/VideoPlayer.java:124: error: cannot find symbol
            dialog.getWindow().getInsetsController().hide(WindowInsets.Type.statusBars());
                                                                      ^
  symbol:   variable Type
  location: class WindowInsets
<path_to_ionic_project>/platforms/android/app/src/main/java/com/moust/cordova/videoplayer/VideoPlayer.java:124: error: cannot find symbol
            dialog.getWindow().getInsetsController().hide(WindowInsets.Type.statusBars());
                              ^
  symbol:   method getInsetsController()
  location: class Window

To fix build for myself I've pinned version of plugin that I use to #5c83c858ed159d68cce1bf54e31d6caf7e145fbf

NBAMj commented 3 years ago

There is only 1 readme change in this commit #5c83c858ed159d68cce1bf54e31d6caf7e145fbf? How is it fixing this issue?