search

moustakas / SGA

Code and papers for the Siena Galaxy Atlas (SGA-2020).
MIT License
10 stars 2 forks source link

SGA and LEDA links incorrect, should be used by objname instead #79

Closed TriShotFlurry closed 7 months ago

TriShotFlurry commented 7 months ago

@moustakas The links to the objects are connected by the PGC number and not the designation. The PGC in these galaxies are set up entirely wrong especially affecting the galaxies with the designation as SDSS or 2MASX identifier, which displays an error. Try changing the link properties from name only.

dstndstn commented 7 months ago

Hi, If you're talking about a web page, PLEASE include a link to an example web page with the problem. Then, say what the link currently is, and what the link should be instead. Thanks, dustin

TriShotFlurry commented 7 months ago

Hi Dustin, sorry for the late reply, the notifications refuse to pop up on me! 😣

I have investigated a few SGA-2020 galaxies and their links were incorrectly set to pgc, and LEDA does not support search. Please change that link search to objname for it to work correctly.

For example: https://www.legacysurvey.org//viewer-dev?ra=189.3616&dec=26.0766&layer=ls-dr9&zoom=15&sga-parent&sga http://leda.univ-lyon1.fr/ledacat.cgi?o=PGC4334605 should be http://leda.univ-lyon1.fr/ledacat.cgi?o=SDSSJ123726.79+260435.5

I investigated all these galaxies and the PGC number is set to all SGA-2020 and SGA-PARENT galaxies.

dstndstn commented 7 months ago

Done in https://github.com/legacysurvey/imagine/commit/8afe16231b09d67a98e2a0c74a6f7464e9b3bc6a

dstndstn commented 7 months ago

@TriShotFlurry can you please check that this fixes the problem you're reporting, and that it doesn't mess up other ones? thanks.

TriShotFlurry commented 7 months ago

Seems to work like a charm. Thanks!