search

moutard / SubZoom-Proto1

1 stars 1 forks source link

content_factory not working #113

Closed rkorach closed 12 years ago

rkorach commented 12 years ago

@moutard content factory does not adapt the item UI to videos, image searches and so on anymore.

it is because of commit a7e5ef5

oItem._oVisitItem.url() has been replaced by window.location.href which causes the bug. I reversed it and it works, but I want to be sure there wasn't another specific reason you did it.

(btw, is there a way to link a commit number in an issue?)

moutard commented 12 years ago

Not sure I understand ? there is no "window.location.href" in the commit you mentionned

rkorach commented 12 years ago

f@#k! It was the one after sorry > 881c4e6 in ui/.../content_factory.js