search

moutard / SubZoom-Proto1

1 stars 1 forks source link

Alertbox : do not write in localStorage from different places #127

Closed rkorach closed 11 years ago

rkorach commented 11 years ago

actually it seems necessary, and does not introduce any conflict. No change needed.

moutard commented 11 years ago

What is it exactly ? it refers to one of my comment ?

rkorach commented 11 years ago

no it was only for me, but you told me once to file an issue even if it was something I was to fix immediately to keep track I was afraid that changing the value of a localstorage variable from different places could be problematic, so I checked closer. But it's not.

moutard commented 11 years ago

It's problematic if you do it in a thread, like callback function but not a problem in a normal flow.

On Wed, Nov 28, 2012 at 3:06 PM, Raphaël Korach notifications@github.comwrote:

no it was only for me, but you told me once to file an issue even if it was something I was to fix immediately to keep track I was afraid that changing the value of a localstorage variable from different places could be problematic, so I checked closer. But it's not.

— Reply to this email directly or view it on GitHubhttps://github.com/moutard/SubZoom-Proto1/issues/127#issuecomment-10803468.

rkorach commented 11 years ago

because of asynchronous behavior / you don't know when the changes will be performed?

moutard commented 11 years ago

yes

On Wed, Nov 28, 2012 at 3:31 PM, Raphaël Korach notifications@github.comwrote:

because of asynchronous behavior / you don't know when the changes will be performed?

— Reply to this email directly or view it on GitHubhttps://github.com/moutard/SubZoom-Proto1/issues/127#issuecomment-10804346.