search

moutard / SubZoom-Proto1

1 stars 1 forks source link

Type error in engine.js #134

Closed moutard closed 11 years ago

moutard commented 11 years ago

var oRequest = webkitIndexedDB.open(sDatabaseName, iNewVersionNumber); l.96 Uncaught TypeError: Type error

Chrome version v.23.0.1271.95 The branch nostart_chrome_version return an error.

not sure you can create a new request before the end of the previous one. or maybe webkitIndexDb is not define inside a transaction.

rkorach commented 11 years ago

Do you think you can handle this one? I have no possibility to debug on chrome 23 :(

moutard commented 11 years ago

the problem is that iNewVersionNumber is not a number (NaN) oµDB.version = ""

moutard commented 11 years ago

So the version is not 0 by default.

moutard commented 11 years ago

Could you check the branch nostart_chrome_version and close the bug if it's ok.

rkorach commented 11 years ago

It is perfectly working for me on chrome 25 :) Sorry I should have closed the issue before pushing something else.

moutard commented 11 years ago

No worry. Just a reminder it will happen often :)

On Mon, Feb 25, 2013 at 5:36 PM, Raphaël Korach notifications@github.comwrote:

It is perfectly working for me on chrome 25 :) Sorry I should have closed the issue before pushing something else.

— Reply to this email directly or view it on GitHubhttps://github.com/moutard/SubZoom-Proto1/issues/134#issuecomment-14052665.

rkorach commented 11 years ago

Shall we merge no_start_chrome_version with no_startpage ?

moutard commented 11 years ago

I think no_stratpage can be simply removed ? all new stuffs are in nostartpage_chrome_version

On Mon, Feb 25, 2013 at 5:40 PM, Raphaël Korach notifications@github.comwrote:

Shall we merge no_start_chrome_version with no_startpage ?

— Reply to this email directly or view it on GitHubhttps://github.com/moutard/SubZoom-Proto1/issues/134#issuecomment-14052918.

rkorach commented 11 years ago

true.