search

moutard / SubZoom-Proto1

1 stars 1 forks source link

All history items are put in all stories #156

Closed rkorach closed 11 years ago

rkorach commented 11 years ago

When opening a story, all the history items that are not "unclassified" are present. Whatever the story.

Note: when the story is first created, it only has its proper elements. So it seems to be during update that the problem occur.

moutard commented 11 years ago

I took me the whole morning to find it so vicious. it's on branch dbscan2. that I updated, cache also. see a06ff4d5129dc32553eacf7469a281de452fe1ac

you may need to git pull --rebase origin cache so it works.

moutard commented 11 years ago

The problem is more important than Ithough. it's during the initialisation of variables made by class.extend()

i will push my set of tests this afternoon.

rkorach commented 11 years ago

Problem persists even after your commit.

moutard commented 11 years ago

yes i know my tests are broken too but the algo works fine. Can you investigate too, we really need to find this bug.

On Mon, Mar 11, 2013 at 9:05 PM, Raphaël Korach notifications@github.comwrote:

Problem persists even after your commit.

— Reply to this email directly or view it on GitHubhttps://github.com/moutard/SubZoom-Proto1/issues/156#issuecomment-14739260 .

moutard commented 11 years ago

Could you make the test on dbscan2. it seems this branch is working fine.

moutard commented 11 years ago

If i remove the lines 30 and 31 the bug appears but for the moment i have no idea why ?

rkorach commented 11 years ago

Indeed it seems to work better now.

rkorach commented 11 years ago

Fixed by doing all attributes initialization in init. it is a limitation of class.js see 8cbe970