Use uint64 for pointer return vars

moutend / go-wca

Pure golang bindings for Windows Core Audio API. The `cgo` is not required.

MIT License

108 stars 28 forks source link

Closed ThiefMaster closed 1 year ago

ThiefMaster commented 3 years ago

fixes #8

NOTE:

I only tested the mmdGetId fix, but since the code in the other places is pretty much the same I'd expect it to work there as well.
I tried building my test app with GOARCH=386 and it still worked, so I guess uint64 with 32-bit pointers isn't a problem.

emarj commented 3 years ago

I confirm this works on Windows 64bit.

Maybe uintptr instead of uint64 should be more appropriate since it holds a pointer, regardless of the platform you are in:

uintptr is an integer type that is large enough to hold the bit pattern of any pointer.

moutend commented 1 year ago

@ThiefMaster I apologize for missing your contribution. I'm really sorry about that.

Though it's too late, thank you for your contribution. :bow: