search

moutonrebelle / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.
https://dazzling-neumann-3b84cb.netlify.com/pattern-library/#brand
0 stars 0 forks source link

Carousel and current #3

Open moutonrebelle opened 5 years ago

moutonrebelle commented 5 years ago

Hi @thomasjbradley

For some reason, my carousel is not working and when I'm on a page, it shows "current" in teal on top. How can I remove it?

thomasjbradley commented 5 years ago

For the current, the code on these lines is in the wrong place—it should be inside the class="" attribute: https://github.com/moutonrebelle/ecommerce-pattern-library/blob/master/_patterns/header/header.html#L7-L10

Like this:

      <li class="gutter-1-2 {% if page.highlight_nav == 'home' %}current{% endif %}"><a class="current block pad-t-1-8 pad-b-1-8" href="/">Home</a></li>
thomasjbradley commented 5 years ago

The carousel seems to be missing some code, specifically the <label> tags. Refer to “Step 3” where we add the <label> tags inside a list: https://learn-the-web.algonquindesign.ca/courses/web-dev-4/javascript-less-carousel/#step-3

moutonrebelle commented 5 years ago

@thomasjbradley I looked the step 3 but I don't see the difference between the example and mine. I noticed some typos that I fixed and added some code in the CSS. Nothing changed.