search

mouuff / go-rocket-update

Easy to use and modular library to make self updating golang programs
Other
103 stars 11 forks source link

Add ApiURI for gitlab provider #27

Closed julien-noblet closed 1 year ago

julien-noblet commented 1 year ago

It can let us use private server!

I currently use a self-hosted Gitlab server at work and I want to use this powerful package 😃.

Can you review my PR ?

codecov-commenter commented 1 year ago

Codecov Report

Base: 81.13% // Head: 81.55% // Increases project coverage by +0.41% :tada:

Coverage data is based on head (ad9bf37) compared to base (9c4619a). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #27 +/- ## ========================================== + Coverage 81.13% 81.55% +0.41% ========================================== Files 17 17 Lines 652 656 +4 ========================================== + Hits 529 535 +6 + Misses 66 65 -1 + Partials 57 56 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `81.55% <100.00%> (+0.41%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arnaud+Ali%C3%A8s#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/mouuff/go-rocket-update/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arnaud+Ali%C3%A8s) | Coverage Δ | | |---|---|---| | [pkg/provider/provider\_gitlab.go](https://codecov.io/gh/mouuff/go-rocket-update/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arnaud+Ali%C3%A8s#diff-cGtnL3Byb3ZpZGVyL3Byb3ZpZGVyX2dpdGxhYi5nbw==) | `80.30% <100.00%> (+4.49%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arnaud+Ali%C3%A8s). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Arnaud+Ali%C3%A8s)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mouuff commented 1 year ago

Amazing work! Can you add some coverage to it?

julien-noblet commented 1 year ago

Amazing work! Can you add some coverage to it?

Sure! Is it enough?

julien-noblet commented 1 year ago

I'm testing it and there is an issue in downloading archives... I'm working on it!

Please wait before merge.

julien-noblet commented 1 year ago

Sorry wrong configuration of my depot (private vs public 🤦‍♂️ )

Tested and working 🦾

mouuff commented 1 year ago

Perfect, thank you for contributing!