mov-cli / mov-cli

Watch everything from your terminal.
https://mov-cli.github.io/
MIT License
411 stars 36 forks source link

[BUG] Hyperlink problem with URLs that contain semicolons. #251

Closed r3tr0ananas closed 2 months ago

r3tr0ananas commented 2 months ago

@THEGOLDENPRO

vidsrc.to provides a URL with a semicolon; without it, the hyperlink won't be clickable.

I tried to escape it with a backslash, but had no luck.

Without the semicolon, the hyperlink is clickable but doesn't function properly.

Do you have any ideas on how to fix this?

Alternatively, we could display the URL for the user to copy and paste into their browser.

THEGOLDENPRO commented 2 months ago

I think you have to encode that URL using quote() from urllib.parse. Try that.

r3tr0ananas commented 2 months ago

I just tried, but this also does not work.

THEGOLDENPRO commented 2 months ago

ummm 🤔

I was gonna say "can iSH be emulatored on a desktop or something as luckily sadly I don't own an iPhone to debug this closer" but then I realised that wouldn't really help me debug it anyways.

r3tr0ananas commented 2 months ago

I also tried using the webbrowser module, but it doesn't do anything in iSH.

THEGOLDENPRO commented 2 months ago

I'm gonna go see if ani-cli does it any different.

r3tr0ananas commented 2 months ago

btw you can also emulate iSH by just using a alpine linux docker container.

THEGOLDENPRO commented 2 months ago

btw you can also emulate iSH by just using a alpine linux docker container.

ah okay

THEGOLDENPRO commented 2 months ago

Ah I think they do it the same way: https://github.com/pystardust/ani-cli/blob/0bf639c4232538f9cca38571791ac5ccc9eae858/ani-cli#L259-L263

r3tr0ananas commented 2 months ago

we can paste the link directly into the clipboard and then let the user paste it into their browser; This would be a solution to this problem

r3tr0ananas commented 2 months ago

https://github.com/mov-cli/mov-cli/commit/5bac90ef949b76d47717982f12a817363b62dcec